Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a globMatch() built-in matching function #396

Closed
hsluoyz opened this issue Mar 21, 2020 · 1 comment · Fixed by #397
Closed

Add a globMatch() built-in matching function #396

hsluoyz opened this issue Mar 21, 2020 · 1 comment · Fixed by #397
Assignees
@hsluoyz
Labels
enhancement help wanted

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Mar 21, 2020

A previous PR tried to solve this issue with a 3rd-party library: #164

I prefer using Go standard library to do this to avoid more dependency. Based on suggestion here: golang/go#37964, we should use path.Match() to implement it.
@hsluoyz hsluoyz self-assigned this Mar 21, 2020
@dovics dovics mentioned this issue Mar 21, 2020
Merged
@hsluoyz
Copy link
Member Author

hsluoyz commented Mar 22, 2020

Don't forget to add globMatch() to our docs, append this table: https://casbin.org/docs/en/function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a globMatch() built-in matching function
1 participant
@hsluoyz