Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question]why SyncedEnforcer.EnforceEx doesn't use mutex? #777

Closed
zsh1995 opened this issue Apr 28, 2021 · 3 comments · Fixed by #780
Closed

[Question]why SyncedEnforcer.EnforceEx doesn't use mutex? #777

zsh1995 opened this issue Apr 28, 2021 · 3 comments · Fixed by #780
Assignees
@hsluoyz
Labels
bug released

Comments

@zsh1995
Copy link
Contributor

zsh1995 commented Apr 28, 2021

Want to prioritize this issue? Try:

issuehunt-to-marktext

What's your scenario? What do you want to achieve?
SyncedEnforcer.EnforceEx doesn't use mutex, so it can't return a wrong result when LoadPolicy clear the policies
@hsluoyz
Copy link
Member

hsluoyz commented Apr 28, 2021

@closetool

@hsluoyz hsluoyz added bug and removed question labels Apr 28, 2021
@kilosonc
Copy link
Contributor

kilosonc commented Apr 28, 2021 •
edited

@zsh1995 Thanks for report! Is there still any api which hasn't not been implemented?

@zsh1995 zsh1995 mentioned this issue Apr 29, 2021
Merged
@github-actions
Copy link

github-actions bot commented May 6, 2021

🎉 This issue has been resolved in version 2.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: implement EnforceWithMatcher, EnforceEx, EnforceExWithMatcher zsh1995/casbin
3 participants
@hsluoyz @zsh1995 @kilosonc