feat: support AuthnRequest in SAML #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yixiang Zhao <seriouszyx@foxmail.com>
|
@tangyang9464 please review |
|
@Steve0x2a plz review |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yixiang Zhao seriouszyx@foxmail.com
Fix: #368
I added an option as below to determine whether to sign the request. If enabled, the certification should be uploaded to Keycloak Clients. I will update the documentation later.
However, there were some troubles during the development process. The gosaml2 lib seems to have some bugs about this point, and I have opened an issue.
So if enable the option, we will use POST binding instead of Redirect binding.
When tested with Aliyun IDaaS, the certification management function is VIP. And I can't find an option like
Client Signature Requiredin Keycloak. So I suggest disable the option while using Aliyun IDaaS.