Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the sake of god, please fix the "casbin_rule" table name bug #83

Closed
hsluoyz opened this issue Mar 14, 2021 · 0 comments
Closed

For the sake of god, please fix the "casbin_rule" table name bug #83

hsluoyz opened this issue Mar 14, 2021 · 0 comments
Assignees
Labels

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Mar 14, 2021

We already see tons of complaints from the users for such a boring problem, see:

I'm so tired of it. Such bugs are harming our software quality.

What I want to achieve is:

  1. Not a single bug report about the "casbin_rule" or "casbin_rules" table name any more.
  2. For a new user, we always use the new table name "casbin_rule".
  3. We take care of the DB migration. If the user is using old DB table name "casbin_rules", we will create the new table "casbin_rule" and migrate the data from old table to new table. If the user is using a custom DB table name like "abc", we do nothing.
  4. If there's any bugs for newer version of Gorm, then don't update Gorm' version. Don't use a Gorm version with bugs.
  5. Fix any existing bugs with a PR. Then make a release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant