postgres - won't detect whether database exists

[kuchaguangjie]

Repeated database creation:

It will still trying create the database, even I have specified dbname=casbin in gorm dsn:

github.com/casbin/gorm-adapter/v3@v3.2.6/adapter.go:237 ERROR: database "casbin" already exists (SQLSTATE 42P04)

Better create only if not exists yet, I guess.

BTW, the 2nd issue about timezone is moved to: #96

[hsluoyz]

@kuchaguangjie hi, thanks for your bug report! Can you put the 2nd bug to another issue?

[hsluoyz]

@closetool

[kilosonc]

@kuchaguangjie For the first issue, plz see below

NewAdapter is the constructor for Adapter.
Params : databaseName,tableName,dbSpecified
			databaseName,{tableName/dbSpecified}
			{database/dbSpecified}
databaseName and tableName are user defined.
Their default value are "casbin" and "casbin_rule"

dbSpecified is an optional bool parameter. The default value is false.
It's up to whether you have specified an existing DB in dataSourceName.
If dbSpecified == true, you need to make sure the DB in dataSourceName exists.
If dbSpecified == false, the adapter will automatically create a DB named databaseName.

[kilosonc]

@kuchaguangjie For the second issue, plz just use lower case, like timezone=Asia/Shanghai

[hsluoyz]

@closetool see: https://gorm.io/docs/connecting_to_the_database.html#PostgreSQL

[kilosonc]

@hsluoyz In official docs, TimeZone was used https://www.postgresql.org/docs/9.2/datatype-datetime.html#DATATYPE-TIMEZONES.
But I tested timezone and it works.
Could you please try it @kuchaguangjie ?

[kuchaguangjie]

@hsluoyz Moved the 2nd issue to: #96

[kuchaguangjie]

@hsluoyz Thanks, for the db creation issue, after add 3rd param as true in NewAdapter(), and specify dbname in gorm dsn, now it won't create db.

Code:

    dsn := "host=localhost user=postgres password=mypswd port=5432 dbname=casbin sslmode=disable"
    a, _ := gormadapter.NewAdapter("postgres", dsn, true)
    ef, _ := casbin.NewEnforcer("/path/to/rcba_model.conf", a)