Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple request, policy, effect, matcher type #242

Merged
merged 1 commit into from Nov 30, 2021

Conversation

seriouszyx
Copy link
Member

@seriouszyx seriouszyx commented Nov 30, 2021

Signed-off-by: Yixiang Zhao seriouszyx@foxmail.com

Fix: #241

Signed-off-by: Yixiang Zhao <seriouszyx@foxmail.com>
@casbin-bot
Copy link
Member

@tangyang9464 @elfisworking @fangzhengjin please review

@codecov-commenter
Copy link

Codecov Report

Merging #242 (3ef74fd) into master (51e949a) will increase coverage by 0.19%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   65.61%   65.80%   +0.19%     
==========================================
  Files          43       44       +1     
  Lines        2187     2214      +27     
  Branches      393      395       +2     
==========================================
+ Hits         1435     1457      +22     
- Misses        635      640       +5     
  Partials      117      117              
Impacted Files Coverage Δ
...n/java/org/casbin/jcasbin/util/EnforceContext.java 66.66% <66.66%> (ø)
...ain/java/org/casbin/jcasbin/main/CoreEnforcer.java 78.22% <87.50%> (+0.40%) ⬆️
...rc/main/java/org/casbin/jcasbin/config/Config.java 54.83% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e949a...3ef74fd. Read the comment docs.

@hsluoyz
Copy link
Member

hsluoyz commented Nov 30, 2021

@huyphan-tiki @hungpham1309 plz review

@hsluoyz hsluoyz merged commit 64b984d into casbin:master Nov 30, 2021
@huyphan-tiki
Copy link

@hsluoyz looks good to me. Hope this PR will be merged for the next version soon!

@github-actions
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple policy
5 participants