Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize eval and error logs #360

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

HasonHuang
Copy link
Contributor

  • Add exception logs for eval functions for troubleshooting. There is no logs now, there is no way to know why it is false except for debugging
  • Optimize ERROR logs to avoid stack loss. ERROR level logs should be printed with more details.

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@hsluoyz
Copy link
Member

hsluoyz commented Sep 17, 2023

@HasonHuang if you need to update code, just modify commits in this existing PR. Don't open new PRs

@codecov-commenter
Copy link

Codecov Report

Merging #360 (4d16071) into master (3d22ec5) will increase coverage by 0.08%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   69.37%   69.46%   +0.08%     
==========================================
  Files          49       49              
  Lines        2237     2240       +3     
  Branches      398      399       +1     
==========================================
+ Hits         1552     1556       +4     
+ Misses        574      573       -1     
  Partials      111      111              
Files Changed Coverage Δ
src/main/java/org/casbin/jcasbin/util/Util.java 60.60% <25.00%> (+0.81%) ⬆️
...java/org/casbin/jcasbin/util/BuiltInFunctions.java 88.15% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hsluoyz hsluoyz changed the title refactor: Optimize eval and ERROR logs feat: Optimize eval and ERROR logs Sep 17, 2023
@hsluoyz hsluoyz changed the title feat: Optimize eval and ERROR logs feat: optimize eval and error logs Sep 17, 2023
@hsluoyz hsluoyz merged commit a2067cc into casbin:master Sep 17, 2023
4 of 5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants