Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix g2 bug in addNamedDomainMatchingFunc() #363

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

zhuying1999
Copy link
Contributor

@zhuying1999 zhuying1999 commented Oct 20, 2023

After comparing the Go version, I felt that the commented out code was the main cause of NPE.

Fix: #362

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhuying seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Merging #363 (6de6ec6) into master (7297b01) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   69.50%   69.46%   -0.05%     
==========================================
  Files          49       49              
  Lines        2243     2240       -3     
  Branches      399      398       -1     
==========================================
- Hits         1559     1556       -3     
- Misses        573      574       +1     
+ Partials      111      110       -1     
Files Coverage Δ
...ain/java/org/casbin/jcasbin/main/CoreEnforcer.java 77.39% <ø> (-0.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hsluoyz hsluoyz changed the title fix npe feat: fix g2 bug in addNamedDomainMatchingFunc() Oct 20, 2023
@hsluoyz hsluoyz merged commit 55eac5b into casbin:master Oct 20, 2023
3 of 5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when loading model of RBAC with domain and keyMatch
5 participants