Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DefaultLogger feature #371

Merged
merged 3 commits into from
Jan 9, 2024
Merged

feat: add DefaultLogger feature #371

merged 3 commits into from
Jan 9, 2024

Conversation

LMay001
Copy link
Contributor

@LMay001 LMay001 commented Jan 8, 2024

Part of: #367

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@hsluoyz
Copy link
Member

hsluoyz commented Jan 8, 2024

@LMay001 fix:

image

@hsluoyz hsluoyz changed the title fix: sync log from Go to Java feat: add DefaultLogger feature Jan 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (05eeadd) 70.71% compared to head (01d9184) 68.93%.

Files Patch % Lines
...ain/java/org/casbin/jcasbin/log/DefaultLogger.java 2.12% 46 Missing ⚠️
.../java/org/casbin/jcasbin/log/mocks/MockLogger.java 0.00% 16 Missing ⚠️
src/main/java/org/casbin/jcasbin/log/LogUtil.java 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   70.71%   68.93%   -1.78%     
==========================================
  Files          49       52       +3     
  Lines        2240     2318      +78     
  Branches      398      411      +13     
==========================================
+ Hits         1584     1598      +14     
- Misses        549      613      +64     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz hsluoyz merged commit 80502d4 into casbin:master Jan 9, 2024
3 of 5 checks passed
Copy link

github-actions bot commented Jan 9, 2024

🎉 This PR is included in version 1.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants