Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync ModelTest case from Go to Java #373

Merged
merged 10 commits into from
Jan 18, 2024

Conversation

LMay001
Copy link
Contributor

@LMay001 LMay001 commented Jan 15, 2024

fix: sync ModelTest case from Go to Java

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@hsluoyz
Copy link
Member

hsluoyz commented Jan 15, 2024

@LMay001 plz fix:

image

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (80502d4) 68.93% compared to head (9e924e1) 69.00%.

Files Patch % Lines
.../main/java/org/casbin/jcasbin/model/Assertion.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   68.93%   69.00%   +0.06%     
==========================================
  Files          52       52              
  Lines        2318     2326       +8     
  Branches      411      411              
==========================================
+ Hits         1598     1605       +7     
- Misses        613      614       +1     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz hsluoyz closed this Jan 18, 2024
@hsluoyz hsluoyz reopened this Jan 18, 2024
@hsluoyz hsluoyz changed the title fix: sync ModelTest case from Go to Java feat: sync ModelTest case from Go to Java Jan 18, 2024
@hsluoyz hsluoyz merged commit 899dc83 into casbin:master Jan 18, 2024
2 of 6 checks passed
Copy link

🎉 This PR is included in version 1.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@LMay001 LMay001 deleted the fix_model_test branch January 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants