Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationale for using native implementation of WebView #29

Closed
fischermario opened this issue Sep 27, 2023 · 3 comments · Fixed by #33
Closed

Rationale for using native implementation of WebView #29

fischermario opened this issue Sep 27, 2023 · 3 comments · Fixed by #33
Assignees
Labels
enhancement New feature or request

Comments

@fischermario
Copy link
Contributor

Why did you choose to implement the WebView in native code on Android and iOS?

From my perspective there is no real advantage there. It would be better to use the flutter_inappwebview package which supports Android, iOS, macOS and the web. Windows and Linux support could be added using the desktop_webview_window package.

IMHO the main disadvantage of the current solution is the usage of the system's default browser. There you have no control over cookies (that is especially bad when you want to log out from 3rd party provider using the SDK) and you have no fullscreen mode. Even worse on iOS you have to confirm that you really want to open the Casdoor website on the first attempt.

If this appears useful to you I want to offer my help in migrating the SDK to use the packages mentioned above.

@casbin-bot
Copy link

@casbin-bot casbin-bot added the enhancement New feature or request label Sep 27, 2023
@hsluoyz
Copy link
Member

hsluoyz commented Sep 27, 2023

@fischermario sounds good. Can you make a PR?

@fischermario
Copy link
Contributor Author

@hsluoyz Great! I can get started on it right away. Might take a few days as this is a spare-time thing for me. I will open a PR somewhere next week. Please keep this issue open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants