Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend bug:unable to display in the Safari browser #128

Closed
xiaobeiswift opened this issue Jun 22, 2021 · 2 comments
Closed

frontend bug:unable to display in the Safari browser #128

xiaobeiswift opened this issue Jun 22, 2021 · 2 comments
Assignees
@hsluoyz
Labels
bug Something isn't working

Comments

@xiaobeiswift
Copy link

xiaobeiswift commented Jun 22, 2021 •
edited

image

image

image

Unable to display properly in the Safari browser.
os:Mac 11.4 (20F71),Ios 14.6.
safari version:14.1.1 (16611.2.7.1.4)
ua: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.1 Safari/605.1.15
@hsluoyz hsluoyz self-assigned this Jun 22, 2021
@hsluoyz hsluoyz added the bug Something isn't working label Jun 22, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Jun 24, 2021

I found the faulty code:

https://github.com/casbin/casdoor/blob/1e9cca02fc588029500f9649f7dfdc6cf08805b9/web/src/auth/ForgetPage.js#L302

image

@sh1luo we need to refactor all the regexes used for Email and phone and put them into Setting.js . We don't need two Email regexes.

@sh1luo sh1luo mentioned this issue Jun 25, 2021
Closed
@hsluoyz
Copy link
Member

hsluoyz commented Jun 25, 2021

Fixed by: 2ba4474

@hsluoyz hsluoyz closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: safari show bug and synchronize phone regex for regex.go
2 participants
@hsluoyz @xiaobeiswift