feat: fix login with password bug when feature is disabled #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seriouszyx @ComradeProgrammer @Resulte please review |
|
|
|
@notdu fix:
|
|
@hsluoyz fixed, help me to check it again. |
|
@notdu your GitHub user and commit author should be the same person, this is why the CLA doesn't pass
|
notdu
force-pushed
the
fix/security-enable-password
branch
from
3bba346
to
f5666ca
Compare
|
@hsluoyz, i fixed it |
hsluoyz
changed the title
|
🎉 This PR is included in version 1.198.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
zhaobingchun
pushed a commit
to zhaobingchun/casdoor
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent users from logging in with a password through the API when the login with password feature is disabled.
This enhances security on the backend server.