Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server-side search, filter and sorter for all pages #388

Merged
merged 3 commits into from
Dec 25, 2021

Conversation

seriouszyx
Copy link
Contributor

@seriouszyx seriouszyx commented Dec 21, 2021

Signed-off-by: Yixiang Zhao seriouszyx@foxmail.com

Fix: #370

The demo link is http://82.156.216.21:8000/.

I referenced components-table-demo-ajax and components-table-demo-custom-filter-panel. I I extracted the common components and created BaseListPage.js which each of list pages needs to inherit. The code looks like a lot, but many of the operations are similar. Please test in the demo link.

Signed-off-by: Yixiang Zhao <seriouszyx@foxmail.com>
@casbin-bot
Copy link
Contributor

@tangyang9464 please review

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2021

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 24, 2021

@Steve0x2a plz review

Copy link
Member

@Steve0x2a Steve0x2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:)

@hsluoyz hsluoyz merged commit 10a85f2 into casdoor:master Dec 25, 2021
@casbin-bot
Copy link
Contributor

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add server-side search for all pages
5 participants