auto completion was broken in 1.15.0

[azone]

Please see the video below:

macOS version: Sonoma 14.0
Shell: fish 3.6.1

Oct-17-2023.16-10-19.mp4

[casey]

Ahh, that sucks. I don't really know anything about fish, and the completion scripts are auto-generated by clap, so someone else will have to take the lead in debugging this.

[sebdvd]

Hi, I have the same issue, but it's not really because of fish, but because of the sed command used in the fish autocomplete file:

just --list 2> /dev/null | sed -e '1d; s/^\s*\([^[:space:]]*\)[^#]*$/\1/' -e 's/^\s*\([^[:space:]]*\)[^#]*# \(.*\)$/\1\t\2/'

The second sed arg isn't working properly with the native macOS sed command, for example consider this justfile:

# Commands list
help:
  @just --list

The previous command will output this:

	Commands list

You can see that the recipe is missing.

But now the same command with gsed will output the expected result (and fix the autocompletion):

help	Commands list

[l4zygreed]

@azone can you try this PR? 😺

[azone]

@l4zygreed Thanks a lot, but it seems still not working for me...

[sebdvd]

@l4zygreed it works for me 🤷 (currently tested on macOS 14.1 and fish 3.6.1)

[l4zygreed]

@azone have you replaced autocompletion file with new one? 🤔
I placed mine in .config/fish/completions/just.fish
did you test it from PR branch? it's not merged yet 🤡
We have 3 confirmations that it's working, so probably you missed something P:
(also you may need to reload the shell after changing complition file)

[casey]

Fixed by @l4zygreed in #1710. Thank you for the PR!

[azone]

@azone have you replaced autocompletion file with new one? 🤔 I placed mine in .config/fish/completions/just.fish did you test it from PR branch? it's not merged yet 🤡 We have 3 confirmations that it's working, so probably you missed something P: (also you may need to reload the shell after changing complition file)

Oh sorry~, I forgot to switch the branch. It works now!