Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Improve requests validation #4

Open
ovsinc opened this issue Aug 10, 2023 · 3 comments
Open

[Proposal] Improve requests validation #4

ovsinc opened this issue Aug 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ovsinc
Copy link
Contributor

ovsinc commented Aug 10, 2023

At the moment there is no validation of input data at all.
This can lead to both security problems and sudden operational errors.

Security problems

A user (or an anonymous attacker) can organize a DoS attack when resources (for example, RAM) are exhausted, since user requests are not validated (by field size).

Those. Firstly, the user can save a lot of data into the database. Secondly, increase the load when executing requests to retrieve this big data.

Or an anonymous attacker could launch an attack on /signup.

Operational errors

The user can create an object that is used in another object. Which leads to cross problems.

For example, the Cert object contains a certificate for verifying a JWT signature and a key for signing a JWT.
If the user messes up the Cert (there is no validation, so the user might not even know about it) then this will lead to hard to catch access issues.

@ovsinc
Copy link
Contributor Author

ovsinc commented Aug 10, 2023

@hound672
Copy link

hound672 commented Aug 15, 2023

Or an anonymous attacker could launch an attack on /signup.

Validation alone cannot solve the problem; a rate limiter is needed here

@ovsinc
Copy link
Contributor Author

ovsinc commented Aug 15, 2023

Or an anonymous attacker could launch an attack on /signup.

Validation alone cannot solve the problem; a rate limiter is needed here

Agree. The problem can be viewed holistically.

@ISulimanov ISulimanov changed the title Добавить валидацию [Proposal] Improve requests validation Oct 5, 2023
@ISulimanov ISulimanov added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants