Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDBC Driver assumes autoCommit is true #2041

Closed
AlecKazakova opened this issue Oct 9, 2020 · 0 comments · Fixed by #2291
Closed

JDBC Driver assumes autoCommit is true #2041

AlecKazakova opened this issue Oct 9, 2020 · 0 comments · Fixed by #2291
Labels
bug component: drivers/jdbc

Comments

@AlecKazakova
Copy link
Collaborator

Which is a reasonable assumption since a lot of DBs require it, but consumer code can hardcode it to false before sqldelight uses it, which causes hard to debug issues. SQLDelight should throw in this case on a broken assumption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component: drivers/jdbc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that autocommit is set to true before beginning a transaction cashapp/sqldelight
1 participant
@AlecKazakova