Functions cannot be referenced without parenthesis

[JakeWharton]

SQLDelight Version

2.0.0-alpha04

SQLDelight Dialect

postgresql

Describe the Bug

This query fails:

create:
INSERT INTO conversations(created_at, updated_at)
VALUES (LOCALTIMESTAMP, LOCALTIMESTAMP)
RETURNING id
;

This one succeeds:

create:
INSERT INTO conversations(created_at, updated_at)
VALUES (LOCALTIMESTAMP(), LOCALTIMESTAMP())
RETURNING id
;

Can we make the former work? Or at least have an error message saying it has to be executed as a function.

Note, there are a bunch of these: https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-CURRENT

Stacktrace

/Volumes/dev/JakeWharton/thing/src/main/sqldelight/com/jakewharton/thing/db/conversations.sq: (10, 8): No column found with name LOCALTIMESTAMP
09    INSERT INTO conversations(created_at, updated_at)
10    VALUES (LOCALTIMESTAMP, LOCALTIMESTAMP)
              ^^^^^^^^^^^^^^
11    RETURNING id

/Volumes/dev/JakeWharton/thing/src/main/sqldelight/com/jakewharton/thing/db/conversations.sq: (10, 24): No column found with name LOCALTIMESTAMP
09    INSERT INTO conversations(created_at, updated_at)
10    VALUES (LOCALTIMESTAMP, LOCALTIMESTAMP)
                              ^^^^^^^^^^^^^^
11    RETURNING id

[hfhbd]

Recognizing them without the parentheses only works with custom tokens. The same for the better error message, we need to "know" if you want to refer to a column or to the function. LOCALTIMESTAMP is a keyword and we should add these keywords too.

CREATE TABLE foo(id INT);

SELECT LOCALTIMESTAMP, id FROM foo;

IntelliJ also warns you:

BTW DB2 is even worse, eg: SELECT CURRENT DATE; :)

[JakeWharton]

I lied, LOCALTIMESTAMP() does not actually work in the DB, it merely satisfies SQLDelight (incorrectly).

[hfhbd]

Yeah, because SQLDelight thinks, this is a function but does not know if this function actually exists. We should still add LOCALTIMESTAMP too.

[drewd]

Note, I only added the current date/time functions in the section you guys mentioned. There are actually a ton of these: https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-TABLE. More than I think is worth it at the moment.