Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conveniences for animating collection properties #3

Closed
NickEntin opened this issue Jan 19, 2020 · 3 comments
Closed

Add conveniences for animating collection properties #3

NickEntin opened this issue Jan 19, 2020 · 3 comments
Labels
enhancement Request for a new feature or improvement to an existing feature wontfix This will not be worked on

Comments

@NickEntin
Copy link
Collaborator

Currently there isn't a great way to animate a collection of subelements.

For example, say your element has a property containing an array of subviews that should each be animated. If the count is known during construction, you can add each one by key path, but you lose the compiler safety by using indices in the key path. The other option here is to use an AnimationGroup, which brings back the compiler safety but loses the separation of construction and execution.

In order to support building animations of collections for which the number of elements isn't known during construction, we need a new type of content that can be added to the Animation.

@NickEntin
Copy link
Collaborator Author

There's a work-in-progress implementation of this in the framework currently, under the name Collection Keyframes. This enables adding keyframes that will be applied to all elements in a collection. The timestamp for each keyframe can be determined based on the element's index in the collection.

Collection Keyframes are marked as internal since there's still a lot of work left to do, especially around how they interact with other animation content (like how they behave in nested animations).

@NickEntin NickEntin added the enhancement Request for a new feature or improvement to an existing feature label Jan 19, 2020
@NickEntin
Copy link
Collaborator Author

The work-in-progress implementation was removed in #46.

@NickEntin NickEntin added the wontfix This will not be worked on label Jan 4, 2021
@NickEntin
Copy link
Collaborator Author

In the year that this issue has been open, I've haven't heard about this being a pain point at all. I'm going to close it out as a won't-fix for now. If anyone has a use case where this functionality would make a big difference, please comment - it'd be great to hear how this could be improved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a new feature or improvement to an existing feature wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant