Catch all exceptions in wallet API

[sihamon]

Move HTTPException from router to error handler and catch all exceptions in error handler.
Closes #201 .

[codecov]

Codecov Report

Patch coverage: 69.23% and project coverage change: +0.34 🎉

Comparison is base (08ceeda) 56.06% compared to head (ed64b4c) 56.41%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   56.06%   56.41%   +0.34%     
==========================================
  Files          42       42              
  Lines        3328     3311      -17     
==========================================
+ Hits         1866     1868       +2     
+ Misses       1462     1443      -19     

Impacted Files	Coverage Δ
cashu/wallet/api/router.py	76.08% <52.94%> (+6.23%)	⬆️
cashu/wallet/api/app.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AngusP]

Would suggest

Suggested change

	except Exception as exc:
	raise HTTPException(
	status_code=status.HTTP_400_BAD_REQUEST, detail=str(exc)
	)
	except (AssertionError, KeyboardInterrupt):
	# These should never really be caught, 1st is "something real bad" and 2nd is a PITA if something gets stuck
	raise
	except Exception as exc:
	if isinstance(exc, HTTPException):
	# Allows optionally setting a custom `status_code` if desired, but otherwise defaulting to below for convenience
	raise
	raise HTTPException(
	status_code=status.HTTP_400_BAD_REQUEST, detail=str(exc)
	)

[AngusP]

str(exc) probably OK for now, but should be a little cautious about echoing the contents of whatever exception gets raised back to some random person on the internet, it can leak info about the system and make it easier to find vulnerabilities (minor example #228 where the API responses reveal that this mint was running Postgres and CLN specifically)

[AngusP]

Would still recommend passing-up a HTTPException as-is if one is encountered, but could easilly be added later if someone needs this

if isinstance(exc, HTTPException):
    # Allows optionally setting a custom `status_code` if desired, but otherwise defaulting to below for convenience
    raise

---

On the AssertionError, seems assert has been used in a few places so can pass on that suggestion (though IMHO even though assert is shorter, it is best reserved as a thing to actually cause a crash, like if somehow 1 != 1)

[AngusP]

Jokingly suggest using a custom Exception class Cachuww 🤧

[callebtc]

Cash'uwu

[callebtc]

This block can be replaced by simply wallet.load_mint() without try: ... except: ... – achieves the same thing.

[callebtc]

LGTM (pls check comment)