Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Define responses for API #233

Merged
merged 2 commits into from May 22, 2023
Merged

[Wallet] Define responses for API #233

merged 2 commits into from May 22, 2023

Conversation

sihamon
Copy link
Collaborator

@sihamon sihamon commented May 18, 2023

Define responses of wallet API using pydantic's BaseModel and fastapi's response_model.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 89.53% and project coverage change: -0.24 ⚠️

Comparison is base (f0735cf) 55.38% compared to head (49a455e) 55.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   55.38%   55.15%   -0.24%     
==========================================
  Files          41       42       +1     
  Lines        3286     3385      +99     
==========================================
+ Hits         1820     1867      +47     
- Misses       1466     1518      +52     
Impacted Files Coverage Δ
cashu/wallet/api/router.py 69.85% <75.67%> (-0.33%) ⬇️
cashu/wallet/api/responses.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@callebtc
Copy link
Collaborator

Excellent this should make it a lot easier to follow along and generate better documentation, thank you!

@callebtc callebtc merged commit 08ceeda into main May 22, 2023
5 checks passed
@callebtc callebtc deleted the wallet-api-responses branch May 22, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants