Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to start wallet API by cashu --daemon #243

Merged
merged 5 commits into from Jun 8, 2023
Merged

Conversation

sihamon
Copy link
Collaborator

@sihamon sihamon commented May 28, 2023

Closes #202

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage: 68.75% and project coverage change: -0.51 ⚠️

Comparison is base (08ceeda) 56.06% compared to head (1fe1875) 55.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   56.06%   55.56%   -0.51%     
==========================================
  Files          42       42              
  Lines        3328     3324       -4     
==========================================
- Hits         1866     1847      -19     
- Misses       1462     1477      +15     
Impacted Files Coverage Δ
cashu/wallet/api/api_server.py 50.00% <50.00%> (ø)
cashu/wallet/cli/cli.py 48.26% <71.42%> (+0.47%) ⬆️
cashu/core/settings.py 97.43% <100.00%> (+0.06%) ⬆️
cashu/wallet/api/router.py 76.08% <100.00%> (+6.23%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failing for inexplicable reasons.

@callebtc callebtc merged commit 786fbf2 into main Jun 8, 2023
4 of 5 checks passed
@callebtc callebtc deleted the wallet-api-daemon branch June 8, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wallet] Allow API to start with command cashu --daemon
2 participants