Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint: Fakewallet support for USD #488

Merged
merged 5 commits into from Mar 22, 2024
Merged

Mint: Fakewallet support for USD #488

merged 5 commits into from Mar 22, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Mar 22, 2024

  • Add 'usd' support for FakeWallet
  • Fix: After a receive, print balance in the unit of the received token in Wallet CLI, not in the default wallet unit.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 68.42%. Comparing base (f462134) to head (d7b52fc).

Files Patch % Lines
cashu/lightning/fake.py 43.47% 13 Missing ⚠️
cashu/mint/startup.py 0.00% 13 Missing ⚠️
cashu/wallet/cli/cli.py 57.14% 6 Missing ⚠️
cashu/lightning/strike.py 50.00% 2 Missing ⚠️
cashu/lightning/__init__.py 50.00% 1 Missing ⚠️
cashu/lightning/base.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   68.49%   68.42%   -0.08%     
==========================================
  Files          74       74              
  Lines        6707     6758      +51     
==========================================
+ Hits         4594     4624      +30     
- Misses       2113     2134      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 3ba1e81 into main Mar 22, 2024
16 checks passed
@callebtc callebtc deleted the fakewallet-usd branch March 22, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant