CDAP-14161 fix flaky cancel deprovision test #10665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the provisioning tests, we need to call the deprovision method that lets the caller specify what sort of task cleanup to perform. This is to prevent the default behavior, which is to delete task state after a deprovision task is complete, which would not allow the test to verify state.
anew
approved these changes
Sep 12, 2018
albertshau
deleted the
feature/CDAP-14161-fix-flaky-cancel-deprovision
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the provisioning tests, we need to call the deprovision method
that lets the caller specify what sort of task cleanup to perform.
This is to prevent the default behavior, which is to delete task
state after a deprovision task is complete, which would not allow
the test to verify state.