(CDAP-7420) Program lifecycle impersonation #6931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwar6953
reviewed
Oct 11, 2016
| } catch (Exception e) { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| @Nullable |
There was a problem hiding this comment.
does it actually ever return null?
There was a problem hiding this comment.
According to the logic, it's possible. And the caller also checks for it, hence I add the annotation to be clear.
anwar6953
reviewed
Oct 11, 2016
| YarnApplicationReport report = processController.getReport(); | ||
| String host = report.getHost(); | ||
| int port = report.getRpcPort(); | ||
| if (host == null || host.equals("N/A") || port == -1) { |
There was a problem hiding this comment.
I think we should LOG#warn in this case.
|
LGTM; tested on cluster. Squashing commits. |
Refactor the ProgramRuntimeService and wrap the TwillController to minimize places that need to be aware of impersonation
anwar6953
force-pushed
the
feature/CDAP-7420-program-lifecycle-impersonation
branch
from
f6908ee
to
b7ba023
Compare
|
Build green; merging |
anwar6953
deleted the
feature/CDAP-7420-program-lifecycle-impersonation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the ProgramRuntimeService and wrap the TwillController to minimize places that need to be aware of impersonation