[CDAP-8075] Adds ability to interpret Version Ranges for CDAP UI #7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // All numerical part of the version are the same, compare the suffix. | ||
| // A special case is no suffix is "greater" than with suffix. This is usually true (e.g. release > snapshot) |
There was a problem hiding this comment.
This might not be true right? 4.0.0 is not greater than 4.1.0-SNAPSHOT? Or am I missing something here?
There was a problem hiding this comment.
4.0.0 would have been returned as less than 4.1.0 because of the minor comparison before this line. This line will simply compare 4.0.0 with 4.0.0-SNAPSHOT.
The comparisons in order:
- Major
- Minor
- Fix
- Suffix
|
🎉 on Unit tests 💯 |
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.cask.co/browse/CDAP-8075