Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDAP-4176 Add ability to set client timeout in CLI #8401

Merged
merged 3 commits into from Mar 22, 2017

Conversation

Denton-L
Copy link
Contributor

@Denton-L Denton-L added 2.4 4.2 and removed 2.4 labels Mar 21, 2017
Copy link
Contributor

@albertshau albertshau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

"d", "debug", false, "Print exception stack traces.");

private static final Option SCRIPT_OPTION = new Option(
"s", "script", true, "Execute a file containing a series of CLI commands, line-by-line.");

private static final Option TIMEOUT_OPTION = new Option(
"t", "timeout", true, "Sets read timeout of the CLI in seconds.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be more informative if it was "http read timeout" instead of just "read timeout"

@Denton-L Denton-L changed the title CDAP-4716 Add ability to set client timeout in CLI CDAP-4176 Add ability to set client timeout in CLI Mar 22, 2017
@Denton-L Denton-L force-pushed the feature/cdap-4176-set-client-timeout branch from 171dd9a to db589e6 Compare March 22, 2017 16:53
@Denton-L Denton-L force-pushed the feature/cdap-4176-set-client-timeout branch from db589e6 to 3c877ce Compare March 22, 2017 17:59
@Denton-L Denton-L merged commit 21bb6a2 into develop Mar 22, 2017
@Denton-L Denton-L deleted the feature/cdap-4176-set-client-timeout branch March 22, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants