(CDAP-9250) Using reflection to find out the number of arguments getOperationStat… #8490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anew
reviewed
Apr 5, 2017
| int i; | ||
| // Find the getOperationStatus method so that we can check the number of arguments it expects. | ||
| Method[] methods = cliService.getClass().getMethods(); | ||
| for (i = 0; i < methods.length; i++) { |
There was a problem hiding this comment.
A little more concise and safe:
OperationStatus operationStatus;
Method getOperationStatus = null;
for (Method method : getCliService().getClass().getMethods()) {
if ("getOperationStatus".equals(method.getName())) {
getOperationStatus = method;
}
}
if (getOperationStatus == null) {
// throw exception
}
Also, you can move this part to the start of the service so it only needs to be done once.
anew
reviewed
Apr 6, 2017
| @@ -53,6 +56,7 @@ | |||
| */ | |||
| public class Hive14ExploreService extends BaseHiveExploreService { | |||
|
|
|||
| private Method getOperationStatus; | |||
| @Inject | |||
There was a problem hiding this comment.
and a comment what this is for?
| } | ||
| } | ||
| if (getOperationStatus == null) { | ||
| throw new RuntimeException("Failed to get the status of the Hive operation. Unable to find getOperationStatus " + |
There was a problem hiding this comment.
no need for the first sentence. You are not actually getting a status yet :)
…us takes and calling it accordingly.
Nishith
force-pushed
the
bugfix_release/CDAP-9250-Change-getOperationStatus
branch
from
9a754e2
to
f17e260
Compare
Nishith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…us takes and calling it accordingly.