COOK-92 Recipe for cdap user #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf31o2
force-pushed
the
feature/cook-92-user-recipe
branch
from
4350cd9
to
798aa5c
Compare
dereklwood
reviewed
Mar 20, 2017
spec/kafka_spec.rb
Outdated
| @@ -9,6 +9,7 @@ | |||
| node.default['hadoop']['mapred_site']['mapreduce.framework.name'] = 'yarn' | |||
| stub_command(/update-alternatives --display /).and_return(false) | |||
| stub_command(/test -L /).and_return(false) | |||
| stub_command(/getent/).and_return(false) | |||
There was a problem hiding this comment.
i dont think these are actually needed, are they? default behavior didn't change, right?
There was a problem hiding this comment.
Default behavior didn't change, but tests were failing before I put these into the tests. I think ChefSpec needs any shell-based tests stubbed, whether it's in the execution or not. Dunno...
There was a problem hiding this comment.
OK. Figured it out. I originally had create_cdap_user as true by default, which is what prompted this. I just removed them and verified and tests still pass.
|
minor question on the specs, potentially unecessary stubs. otherwise 👍 lgtm |
wolf31o2
force-pushed
the
feature/cook-92-user-recipe
branch
from
798aa5c
to
faf35dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a
cdap::userrecipe, which can be run independently of the other recipes. As such, theuserrecipe is not guarded usingnode['cdap']['create_cdap_user']so it can be included without modifying any other attributes.node['cdap']['cdap_user']namespacecdap::userin base beforecdappackage installation, if configuredNecessary Berksfile changes are in #223 to restrict
windowscookbook.