TEPHRA-171 Added implementation TephraZKClientService which does not depend on the guava service listeners. #115
Conversation
| @@ -29,7 +29,6 @@ | |||
| import com.google.inject.Guice; | |||
| import com.google.inject.Injector; | |||
| import org.apache.hadoop.conf.Configuration; | |||
| import org.apache.twill.zookeeper.ZKClientService; | |||
There was a problem hiding this comment.
Removed all occurrences of Twill's ZKClientService from tephra.
|
|
||
| @Override | ||
| public void startAndWait() { | ||
| ((ServiceDelegate) serviceDelegate).connectToZookeeper(); |
There was a problem hiding this comment.
Explicitly calling connectToZookeeper to synchronously connecting to the zookeeper. This may not be the best method since we require casting here.
|
@chtyim @poornachandra Please take a look. Thanks! |
| /** | ||
| * Initiates service startup (if necessary), returning once the service has finished starting. | ||
| */ | ||
| void startAndWait(); |
There was a problem hiding this comment.
Just call it start and stop.
sagarkapare
force-pushed
the
fix/copy-zk
branch
from
d9d5037
to
cdf1901
Compare
| import java.util.List; | ||
|
|
||
| /** | ||
| * |
|
Just one comment. Otherwise the code change LGTM. Also make sure we don't use |
…depend on the guava service listners.
sagarkapare
force-pushed
the
fix/copy-zk
branch
from
cdf1901
to
2b8b1ee
Compare
|
Thank you @chtyim for the review. Made sure we are not using |
|
Build passed. Merging. |
TEPHRA-171 Added ZkClientService in Tephra which does not extend from…
sagarkapare
changed the title
JIRA: https://issues.cask.co/browse/TEPHRA-171