TEPHRA-119 Clean up TransactionEditCodec handling and fix V4 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public class TransactionEditCodecs { | ||
|
|
||
| private static final TransactionEditCodec[] ALL_CODECS = { |
There was a problem hiding this comment.
Maybe a comment saying that the version used in the codec need to be in the same array index of this array?
There was a problem hiding this comment.
Oh.. actually we don't. All good.
|
LGTM |
ghelmling
added a commit
that referenced
this pull request
Aug 12, 2015
TEPHRA-119 Clean up TransactionEditCodec handling and fix V4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the TransactionEditCodec handling, pulling the existing codecs out of TransactionEdit and into TransactionEditCodecs. Also makes each codec be referenced once so that the version check is not duplicated.