Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit link in preparation of it begin required #272

Merged
merged 1 commit into from May 5, 2013
Merged

Add explicit link in preparation of it begin required #272

merged 1 commit into from May 5, 2013

Conversation

vincecima
Copy link
Contributor

No description provided.

@phinze
Copy link
Contributor

phinze commented May 5, 2013

Nice! 🔗

phinze added a commit that referenced this pull request May 5, 2013
Add explicit link in preparation of it begin required
@phinze phinze merged commit ca8010c into Homebrew:master May 5, 2013

def caveats; <<-EOS.undent
You need to run MenuMeters Installer.app to actually install MenuMeters
EOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nicely done. @phinze, @vitorgalvao could we do something like that for .pkgs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely like this. Together with your link :installer idea, and letting homebrew‐cask take care of the warnings, I think it’s a very acceptable solution.

There’s still the issue, like @phinze mentions on #14, of the installation not being contained within the Caskroom, but I think that is fine as long as it’s explicit in the warning.

There’s also no reason why the installation couldn’t be automatically started (even calling open would suffice), if the user asks for it. There are already casks that download .dmg files with agreements that show an “Are you sure? Y/N” prompt, so “why not”?

faun pushed a commit to faun/homebrew-cask that referenced this pull request Jun 15, 2014
Update IntelliJ EAP releases to 135.815
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants