-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anaconda.rb: use set_permissions #13613
Conversation
We should wait to merge this until we have pushed a new release following #13612. Do we need to increment the DSL version number as well? I.e. |
Oh, right, I keep forgetting we need to do that before features are available.
No, lets keep it as is. In fact, I’ve been thinking we do away with that altogether, at least until we get to a stage other than alpha. Not like not updating the number is having any real consequences, and we should likely focus on getting stuff to work, first. What do you think? |
Since #7530, we've been checking the DSL version headers against a minimum arbitrarily defined at The right way to do this, if we wanted to do it at all, would be to define a For example, say a cask In short, a cask can be installed if and only if its stated DSL version is less than or equal to the |
Right, I understand the goal of the system and how it’s meant work (and agree it’s a win, at the very least in user experience), but the question is, since we’re not actually doing said checks yet, is it worth at all to increment the number until we start performing said checks? |
Actually, if you're on board, I may just add the implementation now, so we can roll it out with this next release. What do you think? |
Sure. Sounds good. |
bfd83cf
to
cfba260
Compare
#13612 is merged and we have a new release, so merging this. |
Merged as 6fb3d5f. |
To be merged after #13612 and a new release.