WIP: Add a cask for Docker for Mac

[lox]

This provides a cask for the new Docker for Mac that is currently in beta release. This is usable now for people with a beta token, but shouldn't be merged until stable versions are released.

Adding a new cask

• Checked there aren’t open pull requests for the same cask.
• Checked there aren’t closed issues where that cask was already refused.
• When naming the cask, followed the token reference.
• Commit message includes cask’s name.
• brew cask audit --download docker-for-mac is error-free.
• brew cask style --fix docker-for-mac left no offenses.
• brew cask install docker-for-mac worked successfully.
• brew cask uninstall docker-for-mac worked successfully.

[vitorgalvao]

You need to fill the PR template. It is not optional.

[vitorgalvao]

This is only to be used when the value is true.

[vitorgalvao]

Thank you for the contribution, but there are a lot of issues with it.

Furthermore, since we can’t actually merge it right now, I’d rather not have PRs lingering indefinitely waiting for an external event beyond our control, particularly since details on the cask can change.

It’s best to just work on the cask when it can actually be merged.

[lox]

As you wish, there are likely going to be lots of people who are looking for this, I figured it would make sense to have at least something in place as a PR so that effort wasn't duplicated.

[vitorgalvao]

As you wish, there are likely going to be lots of people who are looking for this, I figured it would make sense to have at least something in place as a PR so that effort wasn't duplicated.

In the PR template there’s a section where you need to confirm you looked to make sure the cask wasn’t submitted before.

[lox]

Fair enough, I'll revisit when there is a final release and I can address all the points of feedback you raised. Thank you for your time.

[niksy]

Maybe this can be added to https://github.com/caskroom/homebrew-versions in the meantime?

[lox]

@niksy I'm unlikely to contribute to cask again, feel free to use whatever code I started on in this PR.

[arbourd]

For those who came here looking for a versions cask, use a gist to install for now, like this. You can install with brew cask install <link to raw file>.

Thanks for putting this together @lox.

[axelpale]

It is a shame that we cannot just brew cask install docker-for-mac

[neverfox]

@axelpale Not sure I understand. You can use brew cask install docker to get Docker for Mac (or docker-beta for the beta version).

[axelpale]

@neverfox If that is true, great! The earlier replies in this issue left me the feeling that brew cask install docker would install the old docker and not Docker for Mac.

[neverfox]

@axelpale No, but brew install docker (no cask) will install the non-native one.

[axelpale]

@neverfox Oh, good point. I guess pointing out this distinction will help others who come here for the info about the right installation command. Thanks!

[Tset-Noitamotua]

aaam ... still confused ... what will I get when I run brew install docker?

a) Docker for Mac
b) Docker Toolbox (old)

Regarding brew info docker I guess 'Docker for Mac' will be installed.
What about docker-compose, docker-machine etc.? They are all bundled in recent Docker.dmg. Going with brew I need to install the separately?

Cheers
Tset

[romatthe]

@Tset-Noitamotua

Currently:

• brew install docker will simply build from the docker/docker repository. I believe docker-swarm and docker-machine are not included, but there are separate formulas for each of those.
• brew cask install docker-toolbox will get you Docker Toolbox
• brew cask install docker will get you Docker for Mac

Essentially, if you want the new native Docker for Mac implementation, you should go for brew cask install docker. Then you'll need to run Docker.app, which will set up the environment for you, including docker, docker-machine and docker-compose.

That's my understanding at least 😅

[Tset-Noitamotua]

@romatthe
Thanks for clarification. I am running a manual installation for now
but next time will try brew cask install docker.

[HintikkaKimmo]

Thanks @romatthe , took me some time to figure this out. Even after reading this chain I am not sure why it cannot be called docker for mac

[vitorgalvao]

Even after reading this chain I am not sure why it cannot be called docker for mac

Because the token reference must be followed to avoid duplicates, and “for mac” is redundant and nonsensical in most cases.

Yes, some casks may get a bit harder to find, but that’s a more than acceptable tradeoff for a consistent rule that makes most of them better.