Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Black Screen screensaver 1.1 #33687

Merged
merged 3 commits into from May 9, 2017
Merged

Add Black Screen screensaver 1.1 #33687

merged 3 commits into from May 9, 2017

Conversation

simmel
Copy link
Contributor

@simmel simmel commented May 9, 2017

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • sha256 was updated, but version remained the same.
    Post a link to a public confirmation by the developer.:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@vitorgalvao
Copy link
Member

  • sha256 was updated, but version remained the same.
    [Post a link to a public confirmation by the developer.][version-checksum]:

Could you please explain what was unclear, there?

@simmel
Copy link
Contributor Author

simmel commented May 9, 2017

sha256 was updated, but version remained the same.
Post a link to a public confirmation by the developer.:

That could mean so many things.

  1. When was sha256 was updated supposed to happen?
  • When I ran any of the previously mentioned commands?
  • When I updated/added it myself, as in this case?
  1. Who is the developer?
  • Creator of the application?
  • The person adding/updating the cask, me in this case?

I never updated the sha256 in this case, I just added it.
So I shouldn't have clicked that?
Should that be moved to a new headline, like:

Additionally, if updating an existing cask:
[ ] sha256 was updated, but version remained the same.

That would make it clearer to me, at least.
🤷‍♂️

@vitorgalvao
Copy link
Member

@simmel Thank you for the feedback. See #33692. Clearer?

@vitorgalvao vitorgalvao merged commit a4bddd0 into Homebrew:master May 9, 2017
@simmel
Copy link
Contributor Author

simmel commented May 10, 2017

No problem @vitorgalvao! I added another comment on that PR :)

@simmel simmel deleted the add_black_screen_screensaver branch May 10, 2017 06:12
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants