Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eqMac 2.0.7. #37414

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Add eqMac 2.0.7. #37414

merged 1 commit into from
Aug 6, 2017

Conversation

sepehr
Copy link
Contributor

@sepehr sepehr commented Aug 6, 2017

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the [token reference].
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.
  • Checked that the cask was not already refused in [closed issues].

@vitorgalvao vitorgalvao mentioned this pull request Aug 6, 2017
@vitorgalvao
Copy link
Member

We can change its token to eqmac if we merge #37416.

@commitay
Copy link
Contributor

commitay commented Aug 6, 2017

github.com/romankisil/eqMac does not exists.

No, but I don't think we can use #{version.major} in a commented line.


Please rebase and rename the cask to eqmac, thanks!

@sepehr
Copy link
Contributor Author

sepehr commented Aug 6, 2017

No, but I don't think we can use #{version.major} in a commented line.

Seems like that the developer has chose this as part of the application name: "eqMac2". eqMac is the name for its initial release as the homepage comparison table shows.

So what should we do? eqmac or eqmac2?

@commitay

@commitay
Copy link
Contributor

commitay commented Aug 6, 2017

To follow the token_reference the cask should be eqmac

@sepehr
Copy link
Contributor Author

sepehr commented Aug 6, 2017

Rebased and squashed.

@sepehr sepehr changed the title Add eqMac2 2.0.7. Add eqMac 2.0.7. Aug 6, 2017
@vitorgalvao vitorgalvao merged commit 0d00751 into Homebrew:master Aug 6, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants