Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for crashed-node reconnection regression #1418

Open
marc-casperlabs opened this issue May 10, 2021 · 0 comments
Open

Add test for crashed-node reconnection regression #1418

marc-casperlabs opened this issue May 10, 2021 · 0 comments

Comments

@marc-casperlabs
Copy link
Collaborator

#1413 fixed a regression that caused a node not to reconnect to a crashed node. The conditions are somewhat tough to replicate outside of our integration, but it could be possible to add these to the networking tests using testing::Network. We should definitely try to replicate this bug (by temporarily turning off the fix) and add a test for it.

@marc-casperlabs marc-casperlabs self-assigned this May 10, 2021
@marc-casperlabs marc-casperlabs changed the title Add test for crashed-node regression Add test for crashed-node reconnection regression May 10, 2021
@marc-casperlabs marc-casperlabs added this to the 1.4.0 milestone May 10, 2021
@piotr-dziubecki piotr-dziubecki modified the milestones: 1.4.0, 1.5.0 Oct 27, 2021
@piotr-dziubecki piotr-dziubecki removed this from the 1.5.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants