Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send DeployProcessed events to event stream server for historical blocks #3556

Closed
piotr-dziubecki opened this issue Jan 10, 2023 · 0 comments · Fixed by #3569
Closed

Send DeployProcessed events to event stream server for historical blocks #3556

piotr-dziubecki opened this issue Jan 10, 2023 · 0 comments · Fixed by #3569
Assignees

Comments

@piotr-dziubecki
Copy link

piotr-dziubecki commented Jan 10, 2023

We want to replace BlockSynchronizerAnnouncement::CompletedBlock announcement with a hot block announcement, where the hot block state is set up so that only the following events are emitted:

  • deploy_buffer::Event::Block
  • consensus::Event::BlockAdded
  • event_stream_server::Event::BlockAdded
  • event_stream_server::Event::DeployProcessed for each deploy (this will mean the BlockSynchronizer will need to read the corresponding execution results from storage, or retain them in memory)

We also have some nitpicks to resolve:

  • rename hot block to meta block
  • rename State::new_synced() to new_already_stored()
  • remove State::immediate_switch_block_for_current_protocol_version and rename State::new_immediate_switch() to new_should_not_gossip()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants