You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The validator broadcast based on the ValidatorMatrix in feat-1.6 is currently not fixed and was recently tested with a workaround, causing the broadcast to reach all nodes:
rust
for peer_id in self.outgoing_manager.connected_peers() {
total_outgoing_manager_connected_peers += 1;
(in the workaround, the if condition is prefixed with true ||)
The root cause for this code not working is that it does not check adjacent eras (past and future), causing it to break during switch blocks.
The code needs to be reexamined and reengineered to efficiently send at least to current and previous era validators, as well as potential future validators, all without introducing quadratic copies of validator IDs on every message send.
The text was updated successfully, but these errors were encountered:
The feature (selecting nodes based on their validator status) needs to be cleanly readded to the networking component, quick fixes are not going to cut it here.
The validator broadcast based on the ValidatorMatrix in feat-1.6 is currently not fixed and was recently tested with a workaround, causing the broadcast to reach all nodes:
rust
for peer_id in self.outgoing_manager.connected_peers() {
total_outgoing_manager_connected_peers += 1;
(in the workaround, the if condition is prefixed with true ||)
The root cause for this code not working is that it does not check adjacent eras (past and future), causing it to break during switch blocks.
The code needs to be reexamined and reengineered to efficiently send at least to current and previous era validators, as well as potential future validators, all without introducing quadratic copies of validator IDs on every message send.
The text was updated successfully, but these errors were encountered: