Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential arithmetic overflow during highway rewards calculation #4283

Closed
RitaMAllenCA opened this issue Sep 12, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working release blocker PR to be merged before releasing release-blocker

Comments

@RitaMAllenCA
Copy link

There is a potential for arithmetic overflow at https://github.com/casper-network/casper-node/blob/f7d8228de3cb56a3fe705f5a787d3db[…]/components/consensus/highway_core/finality_detector/rewards.rs if the quorum weight is u64::MAX. This can happen if e.g. we have two stakes of au64::MAX and bu64::MAX where each stake is divisible by a+b. Examples of pairs for a and b are (514, 771) or (668, 614).

@RitaMAllenCA RitaMAllenCA added bug Something isn't working release blocker PR to be merged before releasing release-blocker labels Sep 12, 2023
@RitaMAllenCA RitaMAllenCA assigned fizyk20 and unassigned Fraser999 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release blocker PR to be merged before releasing release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants