Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design & implement reactor style tests for full Zug-compatible rewards process #4317

Closed
SaiProServ opened this issue Oct 4, 2023 · 2 comments · Fixed by #4400
Closed

Design & implement reactor style tests for full Zug-compatible rewards process #4317

SaiProServ opened this issue Oct 4, 2023 · 2 comments · Fixed by #4400
Assignees

Comments

@SaiProServ
Copy link
Collaborator

SaiProServ commented Oct 4, 2023

Follow up to #3914 and #4289

@SaiProServ SaiProServ assigned fizyk20 and real-felix and unassigned fizyk20 Oct 4, 2023
@rafal-ch
Copy link
Contributor

Plan of attack:

  1. Refactor out effect_builder from the reward calculation functions in order to be able to unit test them
  2. Create a sunny-day mockreactor-like test to check if network is emitting rewards info on switch block
  3. (but can happen in parallel with the two above) brainstorm with @fizyk20 and @AlexanderLimonov about potential testing scenarios (for example: validator going down or missing finality signatures, etc.)

@AlexanderLimonov
Copy link
Contributor

Noted

@SaiProServ SaiProServ changed the title Design & implement unit + reactor style tests for full Zug-compatible rewards process Design & implement reactor style tests for full Zug-compatible rewards process Oct 20, 2023
@real-felix real-felix linked a pull request Nov 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants