Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a new transaction type ("new") Deploy #24

Open
piotr-dziubecki opened this issue Jul 14, 2021 · 3 comments
Open

create a new transaction type ("new") Deploy #24

piotr-dziubecki opened this issue Jul 14, 2021 · 3 comments
Assignees
Milestone

Comments

@piotr-dziubecki
Copy link
Contributor

piotr-dziubecki commented Jul 14, 2021

Original idea was to restructure the existing deploy, however, we will keep existing deploy type and create a new "transaction" type. We will deprecate the existing deploy in 2.0, remove the deprecated deploy in 3.0

Requirements:
New type: enum transactionKind which contains a set of enums (Native, NativeTransaction. This new type will then be the union of these new enums:
New Enums: Native, Userland, PricingMode
-- native: enum NativeTransaction (MintTransfer(RunTimeArgs), Auction(enum AuctionTransaction(AddBid(RunTimeArgs))) ReservationIRunTimeArgs)). -- native contracts for the chain, was session
-- Userland: enum UserlandTransaction( Noop, Closed??-- like a pure function i.e. can't call a contract, Installers/Upgraders -- called out so we can allow more space (via module_bytes), DirectCall , standard
-- standard variant is a new size of module bytes that can be much smaller than installers/upgraders.
-- install/upgrade variant is the current module byte size definition for installers/upgraders (large)
-- no more stored sessions
-- DirectCall: StoredContract, ContractByName, ContractByHash // all 4 types.... all 4 channelled in one channel
-- PricingMode: (enum slot, price, ??). -- was gas_price
deploys that do not follow a supported gas_model will not be accepted.
No dependencies field
session changing to new enum
channels defined in chainspec: channel_name - map "kind" to "lane"; types and number per block (allows us to manage block sizes, e.g. how many total installerupgraders, etc)
// prepaid reservations would be the first channel to draw transactions from; calls new native escrow procedure

Reorganize any other existing ExecutableDeployItem fields into the appropriate enum or in the transaction.

@piotr-dziubecki piotr-dziubecki created this issue from a note in Casper roadmap (2021 Q3 Upgrade) Jul 14, 2021
@piotr-dziubecki piotr-dziubecki added this to the 1.4.0 milestone Jul 14, 2021
@piotr-dziubecki
Copy link
Contributor Author

CC @MParlikar

@cspramit
Copy link

cspramit commented Oct 4, 2021

@Fraser999 this surely needs to be done

@cspramit cspramit modified the milestones: 1.4.0, 1.5.0 Oct 4, 2021
@piotr-dziubecki piotr-dziubecki moved this from 2021 Q3 Upgrade to 2021 Q4 Upgrade in Casper roadmap Oct 28, 2021
@Fraser999
Copy link

After looking into the code in a bit more depth, we've decided the first part of this epic needs to be the creation of a CEP.

@piotr-dziubecki piotr-dziubecki added P3 priority three - optional and removed P3 priority three - optional labels Nov 9, 2021
@piotr-dziubecki piotr-dziubecki removed this from the 1.5.0 milestone Nov 9, 2021
@piotr-dziubecki piotr-dziubecki moved this from 2021 Q4 Upgrade to 2022 Q1 in Casper roadmap Nov 9, 2021
@piotr-dziubecki piotr-dziubecki added the P3 priority three - optional label Nov 9, 2021
@piotr-dziubecki piotr-dziubecki moved this from 2022 Q1 to 2022 Q2 in Casper roadmap Jan 28, 2022
@piotr-dziubecki piotr-dziubecki changed the title Support alpha numeric strings in transfer id Deploy restructure Jan 28, 2022
@piotr-dziubecki piotr-dziubecki added P2 priority two and removed P3 priority three - optional labels Feb 4, 2022
@piotr-dziubecki piotr-dziubecki added this to the 2.0.0 milestone Feb 4, 2022
@goral09 goral09 self-assigned this Mar 28, 2022
@RitaMAllenCA RitaMAllenCA changed the title Deploy restructure Changes to Deploy May 4, 2023
@RitaMAllenCA RitaMAllenCA changed the title Changes to Deploy create a new transaction type ("new") Deploy Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Casper roadmap
2022 2.0 Plan
Development

No branches or pull requests

6 participants