Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version for node type definitions #16

Closed
eugirdor opened this issue Sep 6, 2018 · 3 comments
Closed

Incorrect version for node type definitions #16

eugirdor opened this issue Sep 6, 2018 · 3 comments
Labels

Comments

@eugirdor
Copy link

eugirdor commented Sep 6, 2018

The package.json has type definitions for Node.js 7, I believe coming from here:

"@types/node": "^7.0.18",

But Electron 1.8.1+ uses Node.js 8

https://electronjs.org/releases#1.8.1

This causes warnings when you try to use this package with an application that has a dependency on the Node.js 8 type definitions.

error TS4090: Conflicting definitions for 'node' found at '.../node_modules/@types/node/index.d.ts' and '.../node_modules/electron/node_modules/@types/node/index.d.ts'. Consider installing a specific version of this library to resolve the conflict.
@khwaaj
Copy link
Collaborator

khwaaj commented Sep 6, 2018

Good catch, I'll make sure it gets fixed for 1.8.8 (and other future releases).

@khwaaj
Copy link
Collaborator

khwaaj commented Sep 7, 2018

If you have not seen it already I published releases based on Electron 3.0.0-beta.9 and 1.8.8, both of which now has the same node version specified as the original release.

@eugirdor
Copy link
Author

eugirdor commented Sep 7, 2018

Just tried it out, looks good. Thank you for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants