Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Castle.Windsor.Extensions.DependencyInjection depend on abstractions #624

Closed
ikkentim opened this issue Sep 1, 2022 · 2 comments · Fixed by #626
Closed

Make Castle.Windsor.Extensions.DependencyInjection depend on abstractions #624

ikkentim opened this issue Sep 1, 2022 · 2 comments · Fixed by #626
Milestone
v6.0.0

Comments

@ikkentim
Copy link
Contributor

ikkentim commented Sep 1, 2022

Castle.Windsor.Extensions.DependencyInjection currently depends on the implementations of the hosting and logging extensions. It would be nice if it could depend on the abstractions instead.

- <PackageReference Include="Microsoft.Extensions.Hosting" Version="3.1.3" />
- <PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.3" />
+ <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="3.1.3" />
+ <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="3.1.3" />
This was referenced Sep 1, 2022
Closed
Merged
@jonorossi
Copy link
Member

I asked the same question when this was contributed by a previous contributor and was told it had to work that way. Gladly accept the change.

@ikkentim
Copy link
Contributor Author

ikkentim commented Sep 1, 2022

I've attached a pull request for this change.

@jonorossi jonorossi added this to the v6.0.0 milestone Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

Remove some unused dependencies from Castle.Windsor.Extensions.DependencyInjection
2 participants
@jonorossi @ikkentim