Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi module support #101

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

ABHAY0O7
Copy link
Contributor

Implemented support for the analysis of the multi-module projects in the correct way.
If there is any dependency that will cause the build failure, depclean will report it in an extra section of the report i.e. inside
DEPENDENT MODULES FOUND
For more reference see these
#92 (comment) or
#68 (comment).

@ABHAY0O7 ABHAY0O7 changed the title Multi module support Multi module support (4) Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #101 (2a5c170) into master (c7556f0) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #101      +/-   ##
===========================================
- Coverage      6.07%   5.66%   -0.41%     
  Complexity       24      24              
===========================================
  Files            27      29       +2     
  Lines           955    1023      +68     
  Branches        128     137       +9     
===========================================
  Hits             58      58              
- Misses          885     953      +68     
  Partials         12      12              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7556f0...2a5c170. Read the comment docs.

@tdurieux
Copy link
Contributor

Could you rebase this PR?

@ABHAY0O7
Copy link
Contributor Author

Could you rebase this PR?

Ya sure, I will update you in just hours.

Now the depclean-maven-plugin will be able to analyze the dependenct modules of a maven based multi-module java project coorectly
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ABHAY0O7
Copy link
Contributor Author

Hii @tdurieux
I rebased the PR, now it has only one commit with a description message.
Also, now you can easily view and review only the changed files and if there is no issue then you can merge it too. :))

Thank you
Abhay

@ABHAY0O7 ABHAY0O7 changed the title Multi module support (4) Multi module support (1) Aug 15, 2021
@tdurieux tdurieux merged commit 3d95389 into ASSERT-KTH:master Aug 20, 2021
@ABHAY0O7 ABHAY0O7 changed the title Multi module support (1) Multi module support Aug 20, 2021
@ABHAY0O7 ABHAY0O7 deleted the multi-module-support branch August 20, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants