End2end tests for core

[afillatre]

Coverage could still be higher, but this should make new features way more easy to test

[codecov]

Codecov Report

Merging #123 (2658f46) into master (5c13f9d) will increase coverage by 17.24%.
The diff coverage is 67.96%.

@@              Coverage Diff              @@
##             master     #123       +/-   ##
=============================================
+ Coverage     40.62%   57.86%   +17.24%     
- Complexity      192      268       +76     
=============================================
  Files            41       40        -1     
  Lines          1184     1182        -2     
  Branches         87       87               
=============================================
+ Hits            481      684      +203     
+ Misses          662      449      -213     
- Partials         41       49        +8     

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c13f9d...2658f46. Read the comment docs.

[cesarsotovalero]

Hi @afillatre,

Thanks a lot for submitting these improvements.

Can you please resolve the conflicts with the master branch so I can merge it 😄

FYI: I added an extra layer of static analysis checks based on the analysis of imports in source files. This means that DepClean now also checks for usages in the source code of the project, which removes false positives such as lombok and sl4j, see #126

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

68.3% Coverage
0.0% Duplication

[afillatre]

@cesarsotovalero that's done. DefaultCallGraphTest may fail on certain condition, because it tests a class using static members, so either this should be refactored to not be static (best solution IMAO) or any test that calls the DefaultCallGraph should reset it after each method.

[afillatre]

Although, looking at the Gradle project, I updated the methods that get the output folders to get a set of folders. I did not do that refactoring to your new code though. This is not blocking, but may need to be done later.

[cesarsotovalero]

@cesarsotovalero that's done. DefaultCallGraphTest may fail on certain condition, because it tests a class using static members, so either this should be refactored to not be static (best solution IMAO) or any test that calls the DefaultCallGraph should reset it after each method.

I agree, DefaultCallGraph should not be a static class. Some refactoring of this class is needed.