Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored DepCleanMojo #85

Merged
merged 15 commits into from
Apr 17, 2021
Merged

Refactored DepCleanMojo #85

merged 15 commits into from
Apr 17, 2021

Conversation

ABHAY0O7
Copy link
Contributor

  • Removed unused import.
  • Removed unused fields.
  • Removed unused or never thrown Exception.
  • Fix typos.
  • Make searching faster while using configuration ignoredependencies.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@1d4ca64). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #85   +/-   ##
========================================
  Coverage          ?   6.07%           
  Complexity        ?      24           
========================================
  Files             ?      27           
  Lines             ?     955           
  Branches          ?     128           
========================================
  Hits              ?      58           
  Misses            ?     885           
  Partials          ?      12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4ca64...d05abb9. Read the comment docs.

@cesarsotovalero
Copy link
Collaborator

Hi @ABHAY0O7, thanks for this proposal.
Can you add some unit tests along with this PR?

@ABHAY0O7
Copy link
Contributor Author

Hi @ABHAY0O7, thanks for this proposal.
Can you add some unit tests along with this PR?

Hi @cesarsotovalero
I was trying to add a unit test but I faced some problems that I mentioned here #86.
Please help me with this issue, so that I can continue my work.

@ABHAY0O7
Copy link
Contributor Author

Hi @cesarsotovalero
I added an IT for depCleanMojo.
But I don't know how to pass these two failing checks.
Also, I am unable to understand the report generated by these two checks. 😅
So, can you please suggest to me, what can I do to pass these checks?

@cesarsotovalero
Copy link
Collaborator

Hi @cesarsotovalero
I added an IT for depCleanMojo.
But I don't know how to pass these two failing checks.
Also, I am unable to understand the report generated by these two checks. 😅
So, can you please suggest to me what can I do to pass these checks?

Hi @ABHAY0O7,
SonarCloud checks for potential bugs and code smells using static analysis. You can see the report here (notice that these metrics are mostly related to maintainability, so a PR will not be rejected because of not passing this gate). On the other hand, the Codecov report indicates how the PR affects the code coverage of the project, as measured by the unit tests. To not lower down the coverage, it is a good practice to always add unit tests on every PR that you make.

@ABHAY0O7
Copy link
Contributor Author

Hey! @cesarsotovalero I have completed the work.
Now you can review the whole PR.

Thank you.

# Conflicts:
#	depclean-maven-plugin/src/test/java/se/kth/depclean/DepCleanMojoIT.java
@cesarsotovalero cesarsotovalero self-assigned this Apr 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cesarsotovalero
Copy link
Collaborator

Hi @ABHAY0O7, LGTM. Notice that I fixed all the checks before merging. Thanks for your contribution, and keep going!

@cesarsotovalero cesarsotovalero merged commit 47a8b7c into ASSERT-KTH:master Apr 17, 2021
afillatre pushed a commit to afillatre/depclean that referenced this pull request Mar 31, 2022
Co-authored-by: cesarsotovalero <cesarsotovalero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants