New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Options #67
Comments
Hello! |
Hi, wonderful news, thanks for considering everything! |
There is a problem. I don't know why, but Masque doesn't allow to decorate simple plain |
That's really strange, seeing as you can skin Weakauras with Masque which aren't buttons at all (unless Icons in WA are also coded like this)… |
All icons in WeakAuras have disabled buttons attached. This buttons are created only if Masque is installed and enabled. Lua codelocal MSQ, MSQ_Version = LibStub("Masque", true);
local button
if MSQ then
button = CreateFrame("Button", nil, region)
button.data = data
region.button = button;
button:EnableMouse(false);
button:Disable();
button:SetAllPoints();
end |
There is a problem with
NameplateAuras doesn't know anything about aura's maximum duration itself, it knows only current maximum duration. For example, you have some DoT spell that lasts 10 seconds. Okay, NameplateAuras will pulse/glow icon when this DoT's remaining time is 3 sec. Then, you re-apply this DoT. Maximum duration is 13 sec now. This time NameplateAuras will pulse/glow icon on 4 seconds remaining (13*30%=3.9). I don't think it's okay. |
That's exactly as it should be! The pandemic window is always relative to the current maximum duration. That's kept in check by the fact that no matter how often and how early you refresh, the dot from your example will never be longer than those 13 secs. Thus, every pandemic window will be between 30% and 39% of the base maximum duration, but never more. |
I will appreciate if you'll find spare time to try out the latest beta (you can install it via Twitch client or download directly). |
I played around with the two new effects a little bit. The Flash effect is perfect as it is. The Pulse effect seems to be anchored at the top left of the icon, so that it grows to the botttom right. This should probably be centered. Also, the size of the Pulse effect is pretty large for me, but that is probably because my icons are relatively small (17 or 18 px). I guess if you do not want to add sliders for Flash frequency and Pulse size (luxury and all that), you could tie the Pulse effect to an icon scale parameter, where you just set a fixed pulse size that looks right for, say, 40px icons and then automatically scale that proportionally to where the user sets the icon size. (i.e.: if 20px icon, then 50% pulse size etc.) |
TBH I just can't make scale animation work :D So now it's just a stub. I'll return to it a bit later. Masque support will not be implemented. I have managed to negate impact on fps , but... Um, it is not just 'call function from Masque and style is applied', it requires to add 'another way of doing things' to spell handling mechanism just because Masque supports only buttons, but NAuras icons are not buttons and were not intended to work as buttons from the very begining of developing this addon. Features from #74 are implemented, so you can make border texture from any Masque style by yourself. |
Pandemic Windows. |
Tested the new features, both the custom border texture option and the relative time (pandemic) support are working perfectly! I am seeing some bugs with the timer text color/alphas though: (1) The alpha slider seems to be inverted, ie. 0 alpha at the top ("+") of the slider and 100 alpha at the bottom ("-"). Example: I have set the color of the <1m segment to "white, 50% alpha" and the <5s segment to "red, 100% alpha". When I refresh the debuff at <5s, it becomes "white, 100% alpha". Example 2: I set color of the <1m segment to "white, 0% alpha" and the <5s segment to "red, 100% alpha". When I refresh the debuff at <5s, it becomes "white, 100% alpha" AND when it reaches <5, it becomes "red(?), 0% alpha. |
This is serious bug, but seems like I cannot reproduce it. Are you doing as I am? |
Love the functionality and the customization setup!
The only things I'm missing are a couple of (mostly) visual options, maybe they could make it into the addon one day…
Adding Masque support/functionality would be a dream!The text was updated successfully, but these errors were encountered: