Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3u Playlist option doesn't work #26

Open
PassiveLemon opened this issue Oct 20, 2022 · 6 comments
Open

M3u Playlist option doesn't work #26

PassiveLemon opened this issue Oct 20, 2022 · 6 comments
Labels
Feedback requested Work was done regarding the issue, feedback is required if the issue is fixed.

Comments

@PassiveLemon
Copy link

I'm on Windows 10. I have M3u playlist option enabled and after all of the songs are either done downloading or already downloaded, it just repeats:
"Playlist m3u8 checking ID #############"
"Playlist ############# Has some items left to download"
There is also no info on it in the readme so I'm not sure if there is something I am missing.

@casualsnek
Copy link
Owner

I just figured playlist creation fails if any item on playlist is at unavailable state in Spotify. I think this is the issue.
Can you check downloads tab to see if any playlist items has 'Unavailable' status ?

@PassiveLemon
Copy link
Author

I do have a playlist that had 4 unavailable items but this happened for my other playlists that don't have any unavailable items. It didn't matter whether any downloads failed, failed and then got re-downloaded, already had some downloaded, or successfully downloaded all of the songs in one go, it never made the m3u

@casualsnek
Copy link
Owner

I will check the issue and update the comment when i make changes.

@PassiveLemon
Copy link
Author

image
Just in case this helps

@vortex91
Copy link

vortex91 commented Apr 6, 2023

I fixed the code to handle "unavailable" and "failed" use casee.
runtimedata.py: added "missing"
downlowder.py: added "missing.add(trk_track_id_str)" to " if not is_playable:" and "except Exception:"
utility: changed logic of ddc to "set(downloaded_data.keys()).union(missing)" and " if track_id in missing:"

users can unzip and replace in proper folders the 3 files with the attachment and it will create m3u when unavaialble or failed to download

edits.zip

@casualsnek
Copy link
Owner

This should be fixed in development branch, can you try again if the playlist feature works as expected ?

@casualsnek casualsnek added the Feedback requested Work was done regarding the issue, feedback is required if the issue is fixed. label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback requested Work was done regarding the issue, feedback is required if the issue is fixed.
Projects
None yet
Development

No branches or pull requests

3 participants