Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Store album art as a separate file in the album folder #88

Open
artofsound opened this issue Aug 21, 2023 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@artofsound
Copy link

artofsound commented Aug 21, 2023

I want an option to store the album art as a additional file in the same folder, where the downloaded track is stored.
Saving the album art should be done, after downloading all of the album tracks. Doesn't need to be after every single track.

Probably something like "cover.jpg" should do the trick, but maybe you could add a filename option, so users could change it on their behalf.

@casualsnek casualsnek added the enhancement New feature or request label Sep 5, 2023
@NiciTheNici
Copy link

bump, this is insanely useful for rockbox users

@NiciTheNici
Copy link

I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as cover.png all the time like I did in my fork?

https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file

@casualsnek
Copy link
Owner

I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as cover.png all the time like I did in my fork?

https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file

This being a default behavior won't be too bad as i have seen a lot of media player use it instead of embedded one or using embedded ones only if cover.png is missing !

Good to know you got it working, normally i wold have suggested you to make a PR, but since i am rewriting onthespot all PR and non critical Issue resolution are paused right now. I may make this a default behavior but configurable using the config files in the rewrite.

@artofsound
Copy link
Author

I also have a version that works on my fork, even with a settings option you can tick. I used .jpg tho, because that's what Spotify gives you.
If the file already exists, it skips it.

https://github.com/artofsound/onthespot/tree/cover_image

Screenshot 2023-10-31 093232

@NiciTheNici
Copy link

I used .jpg tho, because that's what Spotify gives you.

Ah I just used png because that's what the method set_music_thumbnail used a few lines above my text. Not unnecessarily converting between formats is probably more efficient...

If the file already exists, it skips it.

Same!

I may make this a default behavior but configurable using the config files in the rewrite.

Sounds perfect! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants